Fix: Don't use temp folder name in output folder path #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 95.43% 95.31% -0.13%
==========================================
Files 31 31
Lines 4007 4009 +2
Branches 4007 4009 +2
==========================================
- Hits 3824 3821 -3
- Misses 96 101 +5
Partials 87 87 ☔ View full report in Codecov by Sentry. |
TinyMarsh
approved these changes
Feb 25, 2025
|
You'll only see the bug if you use the cargo run example run simple |
alexdewar
force-pushed
the
fix-example-output-folder-name
branch
from
74fa465 to
f286a49
Compare
alexdewar
force-pushed
the
fix-example-output-folder-name
branch
from
f286a49 to
ec46835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use the name of the folder the input files are in as a proxy for the model name, specifically when creating the output folder for the model run (e.g. you get something like
muse2_results/my_model_name). Unfortunately when extracting the bundled example input files, we use a temporary folder, so you get something likemuse2_results/.tmp4eU71Yinstead. Fix by making a subfolder with a proper name in the temp folder.Fixes #374.
Type of change
Key checklist
$ cargo test$ cargo docFurther checks